-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ConfigConnector configuration option (beta) #547
Add ConfigConnector configuration option (beta) #547
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@redbaron thanks for the PR! You will need to run make build
after making changes to the template for it to propagate to all our beta modules.
11417f7
to
5be6fc7
Compare
@bharathkkb , thanks, I did just that, but still no luck :( |
5be6fc7
to
77c595a
Compare
@redbaron looks like the main issue is that only the beta modules provider version was bumped to After this, you can also run the lint test locally by doing |
@bharathkkb , thanks, will do. It's a bit inconvenient that external contributors can't see CI logs :( |
77c595a
to
33cc7ff
Compare
@redbaron absolutely agree, we are working on something that will let external contributors see CI logs soon 😃 terraform-google-kubernetes-engine/test/integration/beta_cluster/controls/gcloud.rb Line 58 in d1e5d12
|
33cc7ff
to
8922159
Compare
@bharathkkb , any idea what it might be this time? :) |
error doesnt seem related, this LGTM. I am re running to check. |
No description provided.