Bugfix/acm param defaults #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebasing from upstream
…e_container_cluster
…e_container_cluster
…aults instead of shadowing them
chore: Generate docs for workload identity submodule (#532)
…m-google-kubernetes-engine into bugfix/acm-param-defaults
bharathkkb
reviewed
May 23, 2020
morgante
suggested changes
May 26, 2020
…ot good feedback to remove unnecessary detail
|
hey, sorry -- i made a simplication but missed your helpful suggestion. can i trouble you to review and if ok, accept the PR; if you'd prefer the language suggested, that's cool and i can merge it in and regen docs and resubmit |
morgante
approved these changes
Jun 4, 2020
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
* edits to the some param descriptions to clarify use relative to google_container_cluster * edits to the some param descriptions to clarify use relative to google_container_cluster * terraform fmt fixes * now ignore setting un specified policy dir, uses configmanagement defaults instead of shadowing them * now also use configmanagement defaults for sync branch * ran docs * focused the param descriptions some, as they were a bit verbose and got good feedback to remove unnecessary detail * regenerating docs after the change to make descriptions more concise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some bug fixes for param behavior for acm and configsync. removes shadow default values in these modules and allows module users to forgo params like policy dir and sync branch that have default values in the configmanagement resource.