-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infrastructure for creating a binary authentication attestor #530
Infrastructure for creating a binary authentication attestor #530
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
-
Looks like we are missing a Readme similar to this
-
Additionally it would be great, if you can add an example with this module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the CI failed to run on latest commit due to a GitHub outage.
Left a few comments, particularly some nits the linter may have caught if it ran. You can also run it locally using the command make docker_test_lint
. More details here.
Additionally most of our modules have an example, which we use to showcase how the GKE module works alongside other add-on modules. As this can exist without a referencing a GKE cluster, I will defer to @morgante on how to proceed.
… of files and automated hooks for auto-documenting feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall.
Tests failed due to missing variable project_id.
Co-authored-by: Bharath KKB <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mike-ensor looks like just these two needs to be fixed for linting to pass #530 (comment) and #530 (comment). You can also run it locally using the command make docker_test_lint
. More details here.
I've updated the outputs file, run both the "generate docs" and "lint" tools without errors. |
@bharathkkb I'm not sure why the build is failing in GitHub, but it might be related to the failure of the |
@mike-ensor looks like |
@bharathkkb yes, I didn't run the create docs after :-( the build is running now |
This is a module that can be used to create an Attestor for the Binary Authorization workflow. Outputs include the full path/name to the attestor and the full path/name to the associated key