-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add KALM config #528
Add KALM config #528
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need to bump the beta provider to 3.21.0
to get tests passing.
Okay, beta provider updated in /autogen/version.tf.tmpl |
@c0ffeec0der you will need to update the providers in examples which use the beta-modules as well. If you do |
…te-variant README.md
I ran make docker_test_lint and it found a lot of errors (attached). But i think most is not related to the change, rather to windows character formatting. So I did some guesswork here and think the modules in examples folder get the beta version from test/setup/versions.tf . I have updated the file. Is the test on your end still failing? If you could supply the result of make docker_test_lint on your end, I'll make the changes in the code |
Sure, here are the logs: https://gist.github.com/bharathkkb/f1298ef2629c1ce0f25f30fea3de0c71 |
Ah okay, so I have updated the failing version in /examples But the ones in /test/fixtures doesn't seem to specify provider version. It looks like it use the same one in /examples? I see the second trigger of the cloud build successful. Is that the lint check? If there is still error, let me know how to fix the one in /test/fixtures, because I couldn't find the provider version explicitly mentioned in that one. Thanks |
I apologize for the back and forth, we are working to surface these logs to make contributing easier 😃 And yes, the ones in fixtures don't need them as we have set in the examples. LGTM overall. However we need to make sure that the issue mentioned here #428 does not happen. I think this was fixed in the provider but I am happy to give this a whirl and confirm. @morgante I think int tests are failing due to the cloudbuild service account unable to copy the acm yaml from GCS. Could you PTAL? |
No worries, always happy to help :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Enabling/disabling seems to updating in-place as expected.
Add KALM config