Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable GKE_METADATA_SERVER as node_metadata for beta-clusters (#490) #512

Merged
merged 2 commits into from
May 6, 2020
Merged

Enable GKE_METADATA_SERVER as node_metadata for beta-clusters (#490) #512

merged 2 commits into from
May 6, 2020

Conversation

schostin
Copy link
Contributor

@schostin schostin commented May 6, 2020

Fixes #490.

Since workload identity is enabled by default for beta-clusters, GKE_METADATA should be the default for exposing metadata to running pods as well in order to enabled workload identity in full.

@sneb-senacor
Enable GKE_METADATA_SERVER as node_metadata for beta-clusters by defa…
872ecd4 
…ult.

Fixes #490. Since workload identity is enabled by default for beta-clusters, GKE_METADATA should be the default for exposing metadata to running pods as well in order to enabled workload identity in full.
@schostin
Copy link
Contributor Author

schostin commented May 6, 2020

Some local tests fail atm due to Google Compute Engine: Not all instances running in IGM after 16.026802185s. Expect 1. Current errors: [GCE_STOCKOUT]: Instance 'gke-node-pool-cluster-rq5o-pool-02-91cb342f-j5lm' creation failed: The zone 'projects/ci-gke-xxxx/zones/us-central1-a' does not have enough resources available to fulfill the request. Try a different zone, or try again later.. Since this has nothing to do with my changes, I will run the tests later today / tomorrow once I am able to create the resources and run the tests...

The tests in beta_cluster are working fine and therefore I already present this PR for review.

@schostin schostin marked this pull request as ready for review May 6, 2020 12:18
@schostin schostin requested review from bharathkkb, Jberlinsky and a team as code owners May 6, 2020 12:18
@morgante
Copy link
Contributor

morgante commented May 6, 2020

@sebastianneb Can you make sure linters pass at least?

@schostin
Copy link
Contributor Author

schostin commented May 6, 2020

Sure, missed one reference. Should be fixed now, at least the linters are green now. Will try to run the tests again tomorrow (every test that references the beta-cluster).

morgante
morgante approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good. Test failure is unrelated (capacity issues)

@morgante morgante merged commit 8e14762 into terraform-google-modules:master May 6, 2020
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
@schostin
feat: Enable GKE_METADATA_SERVER as default node_metadata for beta-cl…
eadf412 
…usters (terraform-google-modules#490) (terraform-google-modules#512)

BREAKING CHANGE: Beta clusters have changed the default to use the GKE_METADATA_SERVER, to use the old option set `node_metadata = "SECURE"`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgante morgante morgante approved these changes

@bharathkkb bharathkkb Awaiting requested review from bharathkkb

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Beta clusters don't automatically enable Workload Identity
3 participants
@schostin @morgante @sneb-senacor