fix!: properly implement additional_ip_ranges_config #2451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: drfaust92 <[email protected]>
|
/gcbrun |
apeabody
changed the title
apeabody
approved these changes
Sep 18, 2025
There was a problem hiding this comment.
Thanks for the contribution @DrFaust92!
Understood it didn't previous work. I'll mark as breaking to be safe, but it's already going into a major version anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2437
apeabody Not sure if this should be considered a breaking change as feature was released broken as i was confused by params names as
additional_pod_ranges_configuses a similarly namedadditional_ip_range_pods. ill align with whatever you decide