Skip to content

Conversation

Daisyprakash
Copy link
Contributor

No description provided.

@Daisyprakash Daisyprakash requested review from a team, apeabody and ericyz as code owners September 10, 2025 18:22
@apeabody apeabody changed the title Changes to make gke components ADC compatible fix: changes to make gke components ADC compatible Sep 10, 2025
Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Daisyprakash

@apeabody
Copy link
Collaborator

/gcbrun

@apeabody apeabody self-assigned this Sep 10, 2025
@apeabody apeabody changed the title fix: changes to make gke components ADC compatible fix: Make GKE components ADC compatible Sep 10, 2025
Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Daisyprakash!

Looks like a few additional changes are required to align the tests with these changes (project > project_id:

terraform_validate ./test/fixtures/gke_autopilot_cluster
╷
│ Error: Missing required argument
│ 
│   on ../../../examples/gke_autopilot_cluster/main.tf line 35, in module "gke":
│   35: module "gke" {
│ 
│ The argument "project_id" is required, but no definition was found.
╵
╷
│ Error: Unsupported argument
│ 
│   on ../../../examples/gke_autopilot_cluster/main.tf line 39, in module "gke":
│   39:   project    = var.project_id
│ 
│ An argument named "project" is not expected here.
╵
terraform_validate ./test/fixtures/gke_standard_cluster
╷
│ Error: Unsupported argument
│ 
│   on ../../../examples/gke_standard_cluster/main.tf line 40, in module "gke":
│   40:   project    = var.project_id
│ 
│ An argument named "project" is not expected here.
╵
terraform_validate ./examples/gke_autopilot_cluster
╷
│ Error: Missing required argument
│ 
│   on main.tf line 35, in module "gke":
│   35: module "gke" {
│ 
│ The argument "project_id" is required, but no definition was found.
╵
╷
│ Error: Unsupported argument
│ 
│   on main.tf line 39, in module "gke":
│   39:   project    = var.project_id
│ 
│ An argument named "project" is not expected here.
╵
terraform_validate ./examples/gke_standard_cluster
╷
│ Error: Missing required argument
│ 
│   on main.tf line 86, in module "node_pool":
│   86: module "node_pool" {
│ 
│ The argument "project_id" is required, but no definition was found.
╵
╷
│ Error: Unsupported argument
│ 
│   on main.tf line 90, in module "node_pool":
│   90:   project  = var.project_id
│ 
│ An argument named "project" is not expected here.

@apeabody
Copy link
Collaborator

/gcbrun

@apeabody
Copy link
Collaborator

/gcbrun

@apeabody apeabody enabled auto-merge (squash) September 11, 2025 22:08
Copy link

@q2w q2w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Daisyprakash Please validate if the regex introduced are RE2 compliant as needed by ADC service. @pawan1210 Could you review the regex once!

name: cluster_telemetry
title: Cluster Telemetry
properties:
type:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is type field of the cluster_telemetry?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apeabody apeabody merged commit 74d37d8 into terraform-google-modules:main Sep 12, 2025
4 checks passed
security_group:
name: security_group
title: Security Group
regexValidation: ^gke-security-groups@[a-zA-Z0-9.-]+\.[a-zA-Z]{2,}$

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Daisyprakash , please test this validation once in autopush UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants