Skip to content

feat(TPG>=6.47)!: add support for rbac_binding_config #2401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 3, 2025
Merged

feat(TPG>=6.47)!: add support for rbac_binding_config #2401

merged 3 commits into from
Sep 3, 2025

Conversation

DrFaust92
Copy link
Contributor

@DrFaust92 DrFaust92 commented Aug 9, 2025 •
edited
Loading

closes #2398

@DrFaust92 DrFaust92 marked this pull request as ready for review August 9, 2025 02:18
@DrFaust92 DrFaust92 requested review from a team, apeabody and ericyz as code owners August 9, 2025 02:18
@DrFaust92 DrFaust92 changed the title feat: add support for rbac_binding_config feat(TPG>=6.47)!: add support for rbac_binding_config Aug 9, 2025
@apeabody
Copy link
Collaborator

/gcbrun

@DrFaust92 DrFaust92 marked this pull request as draft August 12, 2025 01:50
@apeabody
Copy link
Collaborator

/gcbrun

@DrFaust92 DrFaust92 marked this pull request as ready for review August 13, 2025 22:10
@apeabody
Copy link
Collaborator

/gcbrun

@DrFaust92
Copy link
Contributor Author

apeabody rebased 🙇

@apeabody
Copy link
Collaborator

/gcbrun

@DrFaust92
Copy link
Contributor Author

apeabody looks good! thanks!

@apeabody apeabody added the blocked Blocked by some other work label Aug 29, 2025
@apeabody
Copy link
Collaborator

Pending merge for next major release

@apeabody apeabody removed the blocked Blocked by some other work label Sep 3, 2025
@apeabody
Copy link
Collaborator

apeabody commented Sep 3, 2025

/gcbrun

1 similar comment
@apeabody
Copy link
Collaborator

apeabody commented Sep 3, 2025

/gcbrun

apeabody
apeabody approved these changes Sep 3, 2025
View reviewed changes
Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @DrFaust92!

@apeabody apeabody merged commit 2c8b78d into terraform-google-modules:main Sep 3, 2025
4 checks passed
@apeabody apeabody self-assigned this Sep 3, 2025
@release-please release-please bot mentioned this pull request Sep 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apeabody apeabody apeabody approved these changes

@ericyz ericyz Awaiting requested review from ericyz ericyz is a code owner

Assignees

@apeabody apeabody

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add support for rbac_binding_config

2 participants

@DrFaust92 @apeabody