Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: re-align node_config_defaults to cluster types #2256

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Conversation

apeabody
Copy link
Collaborator

@apeabody apeabody commented Jan 28, 2025

  • add logging_variant to Standard, remove from Autopilot
  • remove enable_gcfs from Autopilot (always enabled depending on version)
  • do not create node_pool_defaults.node_config_defaults block on Autopilot

@apeabody apeabody force-pushed the ap/fix-ap branch 7 times, most recently from dfa97f5 to 26223fd Compare January 29, 2025 01:56
@apeabody apeabody marked this pull request as ready for review January 29, 2025 20:05
@apeabody apeabody requested review from ericyz and a team as code owners January 29, 2025 20:05
@apeabody apeabody changed the title fix!: re-align node_config_defaults to cluster type fix!: re-align node_config_defaults to cluster types Jan 29, 2025
@apeabody apeabody enabled auto-merge (squash) January 29, 2025 20:09
@apeabody apeabody merged commit 4df226d into main Jan 29, 2025
8 checks passed
@apeabody apeabody deleted the ap/fix-ap branch January 29, 2025 20:18
apeabody added a commit that referenced this pull request Jan 29, 2025
apeabody added a commit that referenced this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants