feat: Add support for CMEK in Autopilot GKE module #2230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanini-ciandt
changed the title
romanini-ciandt
requested review from
apeabody,
ericyz and
a team
as code owners
…ap key (terraform-google-modules#2224) Signed-off-by: drfaust92 <[email protected]> Co-authored-by: Andrew Peabody <[email protected]>
apeabody
reviewed
Jan 2, 2025
test/integration/simple_autopilot_private_cmek/simple_autopilot_private_cmek_test.go
Show resolved
Hide resolved
…andt/terraform-google-kubernetes-engine into feat/add-cmek-into-autopilot
|
Thanks @romanini-ciandt - Confirmed the new test is now running, can you review the |
@apeabody |
apeabody
reviewed
Jan 22, 2025
Co-authored-by: Andrew Peabody <[email protected]>
apeabody
reviewed
Jan 23, 2025
There was a problem hiding this comment.
Thanks @romanini-ciandt - One question, otherwise this LGTM
apeabody
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to make GKE Autopilot submodule accept CMEK as input.