Add beta support for confidential_nodes #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stenalpjolly
requested review from
bharathkkb,
Jberlinsky and
a team
as code owners
This comment has been minimized.
This comment has been minimized.
morgante
suggested changes
Nov 1, 2021
| dynamic "confidential_nodes" { | ||
| for_each = local.confidential_node_config | ||
| content { | ||
| enabled = confidential_nodes.value.enabled |
There was a problem hiding this comment.
For future reference, it's usually more intuitive to just hard-code this (enabled = true).
There was a problem hiding this comment.
I thought this would be more aligned with existing code like
There was a problem hiding this comment.
Yes, that's an anti-pattern though.
autogen/main/variables.tf.tmpl
Outdated
| @@ -614,6 +614,12 @@ variable "shadow_firewall_rules_priority" { | |||
| } | |||
|
|
|||
| {% if beta_cluster %} | |||
| variable "enable_confidential_node" { | |||
There was a problem hiding this comment.
Suggested change
| variable "enable_confidential_node" { | |
| variable "enable_confidential_nodes" { |
| @@ -0,0 +1,72 @@ | |||
| /** | |||
There was a problem hiding this comment.
Thank you for adding a test! However, we're trying to avoid too many examples. Could you instead consolidate this by adding confidential notes to one of the existing examples/tests?
morgante
suggested changes
Nov 2, 2021
| @@ -64,6 +64,8 @@ module "gke" { | |||
| }, | |||
| ] | |||
|
|
|||
| enable_confidential_node = true | |||
morgante
approved these changes
Nov 2, 2021
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…es#1040) * Add beta support for confidential_nodes * Cannot use a null value in for_each * Add example and test * Add example and test * Update test name * Review Comments * Review Comments * Review Comments Co-authored-by: Stenal P Jolly <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #737