[ready] [breaking] Added monitoring_config and logging_config variables to beta clusters #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rosmo I assume this is to allow enabling new |
morgante
suggested changes
Oct 18, 2021
morgante
suggested changes
Oct 19, 2021
There was a problem hiding this comment.
Since you increased the minimum required version, versions in examples will need to be updated.
|
Thanks for the PR! 🚀 |
…riables to beta clusters and updated provider version.
I updated all the examples to the newer provider version. |
morgante
approved these changes
Oct 27, 2021
|
This should be merged in our next breaking release. |
morgante
changed the title
|
@rosmo Can you review the conflicts? |
Merged
morgante
approved these changes
Dec 16, 2021
|
Did anyone get this change to work? I'm getting issue of not being able to use it at all, getting errors as in this issue: hashicorp/terraform-provider-google#10361 |
bharathkkb
pushed a commit
that referenced
this pull request
Jan 21, 2022
…nts variables to beta clusters (#1028)
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…nts variables to beta clusters (terraform-google-modules#1028)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related changes: hashicorp/terraform-provider-google#10125