Allow cleanup of buckets even if there are objects in them #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! 🚀 |
morgante
suggested changes
Mar 22, 2021
variables.tf
Outdated
| variable "helm_chart_version" { | ||
| type = string | ||
| default = "4.2.4" | ||
| description = "Helm chart version to install during deployment" | ||
| } | ||
|
|
||
| variable "allow_future_deletion" { |
There was a problem hiding this comment.
Suggested change
| variable "allow_future_deletion" { | |
| variable "allow_force_destroy" { |
morgante
approved these changes
Apr 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #49
I named the variable a bit generic because when we upgrade the google provider, deleting the google_sql_database_instance will require an additional flag, and I figured we could reuse this variable.