Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update so we don't rebuild the domain used for output.gitlab_url #62

Merged
merged 2 commits into from
Oct 27, 2020

Conversation

bgood
Copy link
Collaborator

@bgood bgood commented Oct 27, 2020

In main.tf local.domain is calculated using the var.domain and local.gitlab_address. However, in the outputs we rebuild the domain using local.gitlab_address. I think we should just use local.domain to build the output value for gitlab_url.

Because we rebuild the url using local.gitlab_address, the plan phase can produce this error:

Error: Invalid template interpolation value

  on .terraform/modules/gke-gitlab/outputs.tf line 23, in output "gitlab_url":
  23:   value       = "https://gitlab.${local.gitlab_address}.xip.io"
    |----------------
    | local.gitlab_address is null

In main.tf local.domain is calculated using the var.domain
and local.gitlab_address.  However, in the outputs we
rebuild the domain using local.gitlab_address.  I think we
should just use local.domain to build the output value for
gitlab_url.
@morgante morgante merged commit 5248208 into terraform-google-modules:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants