feat: add support for lifecycle rules in simple bucket #49
Conversation
umairidris
changed the title
| # Object with keys: | ||
| # - type - The type of the action of this Lifecycle Rule. Supported values: Delete and SetStorageClass. | ||
| # - storage_class - (Required if action type is SetStorageClass) The target Storage Class of objects affected by this Lifecycle Rule. | ||
| action = any |
There was a problem hiding this comment.
nit: Are we switching to any to keep the end user configs more concise?
vs main module types
terraform-google-cloud-storage/variables.tf
Line 132 in a0782d7
There was a problem hiding this comment.
Right, this is a temporary type and is due to the fact that terraform does not support optional keys in objects.
In the main module, I am guessing you always need to set storage_class on the action to empty or null, even if you only want to set type?
Once Terraform can support optional keys then we can describe the entire schema.
Note: if the user tries to use any other type it will cause an error so this is relatively safe. The only major downside is it won't catch any extra fields set in the object.
There was a problem hiding this comment.
Note: also can't use map(string) without breaking the interface like how the main module forces matches_storage_class to be a string instead of list of strings like the underlying API. I believe any is better than map(string) because it lets you preserve the underlying API.
There was a problem hiding this comment.
yeah I agree. any lgtm, I was wondering if making a similar change to any type on the main module is also worthwhile, since it seems to be the best option as we wait for optional keys in obj.
There was a problem hiding this comment.
+1 to backporting this to the main module.
| # Object with keys: | ||
| # - type - The type of the action of this Lifecycle Rule. Supported values: Delete and SetStorageClass. | ||
| # - storage_class - (Required if action type is SetStorageClass) The target Storage Class of objects affected by this Lifecycle Rule. | ||
| action = any |
There was a problem hiding this comment.
+1 to backporting this to the main module.
No description provided.