-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Encrypt bucket with CMEK #325
Feat: Encrypt bucket with CMEK #325
Conversation
@apeabody Can you please review this PR? |
/gcbrun |
|
Can you trigger gcbrun again? |
/gcbrun |
assuming last run was successful, can you trigger it again? I just fixed a bug |
/gcbrun |
|
This looks very similar to this issue hashicorp/terraform-provider-google#7611 Basically service account doesn't get created until api is used and in this case we want to use api after creating keys. I'm open to implement workaround but for most of actual users this will never be an issue. Do you have any suggestion on how to move forward here? |
Latest commit should fix this issue. Please run gcbrun again :) |
/gcbrun |
/gcbrun |
/gcbrun |
Can this be merged? |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @ps-occrp!
This PR encrypts bucket using CMEK if default_kms_key_name is set to null in encryption block for simple_bucket submodule