Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dot on a dash in label value #31

Merged
merged 1 commit into from
Jan 23, 2020
Merged

Replace dot on a dash in label value #31

merged 1 commit into from
Jan 23, 2020

Conversation

Vendin
Copy link
Contributor

@Vendin Vendin commented Jan 23, 2020

I want to create a bucket by verified domain name.
image

I do it through terraform:

Error: googleapi: Error 400: Invalid argument, invalid

  on .terraform/modules/cloud_storage/terraform-google-modules-terraform-google-cloud-storage-c011106/main.tf line 21, in resource "google_storage_bucket" "buckets":
  21: resource "google_storage_bucket" "buckets" {


I do it through web UI:
image

All because of the line, it forbids me to create baskets with domain names through terraforms.
https://github.com/terraform-google-modules/terraform-google-cloud-storage/blob/master/main.tf#L27

Because label value have only hyphens (-), underscores (_), lowercase characters, and numbers are allowed. International characters are allowed.

Label value have only hyphens (-), underscores (_), lowercase characters, and numbers are allowed. International characters are allowed.
@morgante morgante self-requested a review January 23, 2020 15:33
Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@morgante morgante merged commit 8875ebb into terraform-google-modules:master Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants