Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add support for public_access_prevention #218

Conversation

imrannayer
Copy link
Contributor

@imrannayer imrannayer commented Jan 24, 2023

fix #206

BEGIN_COMMIT_OVERRIDE
feat(TPG >= 4.42)!: add support for public_access_prevention (#218)
END_COMMIT_OVERRIDE

@imrannayer imrannayer requested a review from a team as a code owner January 24, 2023 19:56
@imrannayer
Copy link
Contributor Author

@bharathkkb @g-awmalik can u plz review?
Thanks

@scottford-io
Copy link

👍 It would be great to get this reviewed and released. Thank @imrannayer for knocking this out!

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bharathkkb bharathkkb changed the title feat: add support for public_access_prevention feat!: add support for public_access_prevention Feb 2, 2023
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets update it for the submod too

@comment-bot-dev
Copy link

@imrannayer
Thanks for the PR! 🚀
✅ Lint checks have passed.

@bharathkkb bharathkkb merged commit 4469954 into terraform-google-modules:master Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for public_access_prevention
4 participants