-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add support for public_access_prevention #218
feat!: add support for public_access_prevention #218
Conversation
@bharathkkb @g-awmalik can u plz review? |
👍 It would be great to get this reviewed and released. Thank @imrannayer for knocking this out! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @imrannayer
Could you bump min versions to 4.42
https://github.com/hashicorp/terraform-provider-google/blob/main/CHANGELOG.md#4420-october-31-2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets update it for the submod too
version = ">= 4.31, < 5.0" |
@imrannayer |
fix #206
BEGIN_COMMIT_OVERRIDE
feat(TPG >= 4.42)!: add support for public_access_prevention (#218)
END_COMMIT_OVERRIDE