-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Hmac access #181
feat: Hmac access #181
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Changed author and committer info, for passing CLA |
Can someone check this PR? There aren't a lot of changes, only adding a little functionality |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @vkamlov and sorry for the delay
@bharathkkb could you review it again? |
@vkamlov |
Why do the int and lint checks don't execute? |
/gcbrun |
Thanks for the contribution @vkamlov. A maintainer needs to trigger the CI, which I just did for the most recent commit. |
/gcbrun |
Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @vkamlov!
Looks good, done! |
A lot of thanks! |
Hi there!
In this PR I would like to add the possibility of granting HMAC access to service accounts. This will be useful for people, who want to create access to buckets using access keys and secret keys.
If you see what can be better here, feel free to add your changes