Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Hmac access #181

Merged
merged 27 commits into from
Mar 21, 2023
Merged

feat: Hmac access #181

merged 27 commits into from
Mar 21, 2023

Conversation

vkamlov
Copy link
Contributor

@vkamlov vkamlov commented Aug 3, 2022

Hi there!
In this PR I would like to add the possibility of granting HMAC access to service accounts. This will be useful for people, who want to create access to buckets using access keys and secret keys.
If you see what can be better here, feel free to add your changes

@google-cla
Copy link

google-cla bot commented Aug 3, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@vkamlov
Copy link
Contributor Author

vkamlov commented Aug 3, 2022

Changed author and committer info, for passing CLA

@vkamlov
Copy link
Contributor Author

vkamlov commented Sep 13, 2022

Can someone check this PR? There aren't a lot of changes, only adding a little functionality

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @vkamlov and sorry for the delay

@vkamlov vkamlov requested a review from a team as a code owner December 12, 2022 14:21
@vkamlov vkamlov changed the title Hmac access feature feat: Hmac access Dec 28, 2022
@vkamlov
Copy link
Contributor Author

vkamlov commented Jan 19, 2023

@bharathkkb could you review it again?

@comment-bot-dev
Copy link

@vkamlov
Thanks for the PR! 🚀
✅ Lint checks have passed.

@vkamlov
Copy link
Contributor Author

vkamlov commented Mar 21, 2023

Why do the int and lint checks don't execute?

@apeabody
Copy link
Contributor

/gcbrun

@apeabody
Copy link
Contributor

Why do the int and lint checks don't execute?

Thanks for the contribution @vkamlov. A maintainer needs to trigger the CI, which I just did for the most recent commit.

@apeabody
Copy link
Contributor

/gcbrun

@vkamlov
Copy link
Contributor Author

vkamlov commented Mar 21, 2023

Thanks!
Can you merge my changes if everything will be ok?

Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @vkamlov!

@apeabody apeabody merged commit e5e4909 into terraform-google-modules:master Mar 21, 2023
@apeabody
Copy link
Contributor

Thanks! Can you merge my changes if everything will be ok?

Looks good, done!

@vkamlov
Copy link
Contributor Author

vkamlov commented Mar 21, 2023

A lot of thanks!

@vkamlov vkamlov deleted the hmac_access branch March 21, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants