Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add missing lifecycle rules conditions simple_bucket #145

Merged

Conversation

jawnsy
Copy link
Contributor

@jawnsy jawnsy commented Nov 18, 2021

Add the following lifecycle rule conditions:

  • custom_time_before
  • days_since_custom_time
  • days_since_noncurrent_time
  • noncurrent_time_before

Closes: #144

Add the following lifecycle rule conditions:

* custom_time_before
* days_since_custom_time
* days_since_noncurrent_time
* noncurrent_time_before

Closes: terraform-google-modules#144
@comment-bot-dev
Copy link

Thanks for the PR! 🚀
✅ Lint checks have passed.

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @jawnsy

@bharathkkb bharathkkb changed the title Add missing lifecycle rules conditions feat: Add missing lifecycle rules conditions simple_bucket Nov 18, 2021
@bharathkkb bharathkkb merged commit bbb681d into terraform-google-modules:master Nov 18, 2021
@jawnsy jawnsy deleted the jawnsy/add-missing-classes branch November 18, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

simple_bucket is missing some lifecycle rules options
3 participants