Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix default storage class #137

Merged
merged 8 commits into from
Sep 27, 2021
Merged

fix default storage class #137

merged 8 commits into from
Sep 27, 2021

Conversation

philip-harvey
Copy link
Contributor

Fixes #122

@comment-bot-dev
Copy link

Thanks for the PR! 🚀
✅ Lint checks have passed.

@morgante
Copy link
Contributor

Note this will technically be a breaking change.

@philip-harvey
Copy link
Contributor Author

I guess anyone who hasn't changed the default will see what looks like a change happen, even though nothing will actually change since MULTI_REGIONAL = STANDARD. I'm assume that most people had to override the default since it wasn't a good default.

@morgante
Copy link
Contributor

Yeah, we need to flag it as a breaking change just because people will see a diff. But I'm comfortable with doing so.

@morgante morgante merged commit af10280 into terraform-google-modules:master Sep 27, 2021
@philip-harvey philip-harvey deleted the ph-fixdefaultstorageclass branch September 27, 2021 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgante morgante morgante approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The default value for storage_class variable in this module is using deprecated option "MULTI_REGIONAL"
3 participants
@philip-harvey @comment-bot-dev @morgante