Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing lifecycle conditions #135

Merged
merged 6 commits into from
Sep 27, 2021
Merged

fix missing lifecycle conditions #135

merged 6 commits into from
Sep 27, 2021

Conversation

philip-harvey
Copy link
Contributor

@philip-harvey philip-harvey commented Sep 27, 2021

Per documentation: https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/storage_bucket
There were three missing conditions in the lifecycle policy block.
Fixes #134

@google-cla
Copy link

google-cla bot commented Sep 27, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@comment-bot-dev
Copy link

comment-bot-dev commented Sep 27, 2021

Thanks for the PR! 🚀
✅ Lint checks have passed.

@morgante
Copy link
Contributor

Thanks for the PR! Please generate docs, as per contributing instructions. The comment above will warn you on what to do.

@philip-harvey
Copy link
Contributor Author

Done, hopefully ready to merge now. Thanks.

@morgante morgante merged commit bd1d1e7 into terraform-google-modules:master Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lifecycle_rule block is missing many conditions
3 participants