Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct behavior of website and cors variables. #132

Merged
merged 4 commits into from
Sep 17, 2021

Conversation

odise
Copy link
Contributor

@odise odise commented Sep 13, 2021

Please consider this PR as a solution to fix #131.

@google-cla
Copy link

google-cla bot commented Sep 13, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@comment-bot-dev
Copy link

comment-bot-dev commented Sep 13, 2021

Thanks for the PR! 🚀
✅ Lint checks have passed.

@google-cla
Copy link

google-cla bot commented Sep 13, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@odise
Copy link
Contributor Author

odise commented Sep 13, 2021

@googlebot I signed it!

Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this.

@odise
Copy link
Contributor Author

odise commented Sep 17, 2021

Any chance to get this as a new release soon @morgante?

@morgante morgante changed the title fixed websites, cors parameter fix: Correct behavior of website and cors variables. Sep 17, 2021
@morgante morgante merged commit 3e6e7f4 into terraform-google-modules:master Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cors and website parameter ignored
3 participants