Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for CORS #128

Merged
merged 6 commits into from
Sep 10, 2021
Merged

Support for CORS #128

merged 6 commits into from
Sep 10, 2021

Conversation

mkjmdski
Copy link
Contributor

@mkjmdski mkjmdski commented Sep 1, 2021

I've noticed that simple_bucket is missing support for CORS so I decided to add it.

@comment-bot-dev
Copy link

comment-bot-dev commented Sep 1, 2021 •
edited
Loading

Thanks for the PR! 🚀
✅ Lint checks have passed.

@mkjmdski
Copy link
Contributor Author

mkjmdski commented Sep 3, 2021

@morgante could you review this too ?

bharathkkb
bharathkkb requested changes Sep 3, 2021
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @mkjmdski

@mkjmdski mkjmdski requested a review from bharathkkb September 4, 2021 12:55
@mkjmdski
Copy link
Contributor Author

mkjmdski commented Sep 8, 2021

hi @bharathkkb I think this PR is ready to review again :)

@bharathkkb bharathkkb merged commit e6559e9 into terraform-google-modules:master Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkjmdski @comment-bot-dev @bharathkkb