incompatible changes when defining a policy

[mariux]

just a small heads up:

When releasing newer minor versions the last days, you added incompatible changes:

in 1.0.0 we had defined policy = .... which created a bucket policy ... when using the latest the bucket policy is not created anymore even if set and you have to define the policy and add an attach_policy = true attribute.

maybe a good idea to assume you want to attach a policy if you define a policy (not null or "")?

thanks a lot.

[antonbabenko]

Marius,

My bad that this was not introduced in the first release of this module.

Unfortunately, this was not possible to do as you suggest because of a limitation in Terraform which says value of 'count' cannot be computed. There are several related issues in Terraform core, for eg, hashicorp/terraform#13980 .

Before this is 100% fixed in Terraform, we can't do anything better than requiring users to set attach_policy = true together with the policy.

Closing this issue.

Thank you!

[mariux]

still an incompatible change that crashes when relying on semantic versioning.. which can be fixed by increasing version number as this reflects a breaking change.

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.