fix: Fix cache_usage_limits issue when empty map (default value) is provided. #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a bug in terraform provider which causes issues when deploying empty cache_usage_limits block (described here: hashicorp/terraform-provider-aws#36374), passing empty map in var.cache_usage_limits as [var.cache_usage_limits] generates list with one element [ null, ] which causes terraform to pass empty cache_usage_limits hence triggers provider bug.
dszlawski-chaos
changed the title
bryantbiggs
merged commit 2a02a2c
into
terraform-aws-modules:master
14 of 15 checks passed
antonbabenko
pushed a commit
that referenced
this pull request
Sep 9, 2024
## [1.2.3](v1.2.2...v1.2.3) (2024-09-09) ### Bug Fixes * Fix cache_usage_limits issue when empty map (default value) is provided. ([#13](#13)) ([2a02a2c](2a02a2c))
|
This PR is included in version 1.2.3 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in terraform provider which causes issues when deploying empty cache_usage_limits block (described here: hashicorp/terraform-provider-aws#36374), passing empty map in var.cache_usage_limits as [var.cache_usage_limits] generates list with one element [ null, ] which causes terraform to pass empty cache_usage_limits hence triggers provider bug.
Description
Passing empty map in var.cache_usage_limits as [var.cache_usage_limits] generates list with one element [ null, ] which causes terraform to pass empty cache_usage_limits
Motivation and Context
There is a bug in terraform provider which causes issues when deploying empty cache_usage_limits block (described here: hashicorp/terraform-provider-aws#36374), passing empty map in var.cache_usage_limits as [var.cache_usage_limits] generates list with one element [ null, ] which causes terraform to pass empty cache_usage_limits hence triggers provider bug.
Breaking Changes
None.
How Has This Been Tested?
Applied changes with updated module code.