fix: Remove dots from inter_parameter_group_name #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix an internal local name used to create a Parameter Group Family. Current module breaks when using older families and no declared family name, because old names contain dots in the name and this is not allowed for Parameter Group Family names.
Motivation and Context
Module can't create an internal parameter group name when using older families.
Parameter group families do not follow a very strict naming convention in AWS. There are situations like the following:
(https://docs.aws.amazon.com/AmazonElastiCache/latest/red-ug/ParameterGroups.Redis.html)
Also, AWS enforces naming rules for parameter family creation. Notably, item no.5 declares:
(https://docs.aws.amazon.com/AmazonElastiCache/latest/red-ug/ParameterGroups.Creating.html)
So when using the module to create an ElastiCache cluster without a custom name, we get the following error:
Breaking Changes
No breaking changes
How Has This Been Tested?
N/A
I have updated at least one of theexamples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request