Skip to content

Correcting name of module #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 15, 2020
Merged

Correcting name of module #666

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94e1be4
Correcting name of module
AmitThakkar Jan 8, 2020
b9592f5
Merge branch 'master' into patch-1
AmitThakkar Jan 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@ A full example leveraging other community modules is contained in the [examples/

```hcl
data "aws_eks_cluster" "cluster" {
name = module.eks.cluster_id
name = module.my-cluster.cluster_id
}

data "aws_eks_cluster_auth" "cluster" {
name = module.eks.cluster_id
name = module.my-cluster.cluster_id
Copy link
Contributor

@max-rocket-internet max-rocket-internet Jan 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it's called my-cluster on line 40?

module "my-cluster" {

Copy link
Member

@barryib barryib Jan 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. That's why @AmitThakkar fixed the referenced module name in datasources. Or you have to name your module module "eks" { ... } on line 40 to make the exemple works.

Copy link
Contributor

@max-rocket-internet max-rocket-internet Jan 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, I must have been half asleep.

}

provider "kubernetes" {
Expand Down