Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding github issue labels and notes from the Office Hour #24

Merged
merged 4 commits into from
Aug 31, 2021
Merged

feat: Adding github issue labels and notes from the Office Hour #24

merged 4 commits into from
Aug 31, 2021

Conversation

antonbabenko
Copy link
Member

@antonbabenko antonbabenko commented Aug 30, 2021 •
edited
Loading

@terraform-aws-modules/triage-supporters WDYT about labels in common.hcl?

More specifically:

  1. I am thinking to drop the description for all. It is rather obvious by the name anyway.
  2. Can we drop some of the labels we won't be using so much?
  3. Anything missing?

I have applied them all here - https://github.com/terraform-aws-modules/terraform-aws-pricing/labels

Inspiration for the data and colors:

@antonbabenko
Copy link
Member Author

Applied. More feedback?

daroga0002
daroga0002 approved these changes Aug 30, 2021
View reviewed changes
Copy link

@daroga0002 daroga0002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me looks good

@bryantbiggs
Copy link
Member

looks great! :shipit:

@antonbabenko antonbabenko changed the title feat: Adding github issue labels feat: Adding github issue labels and notes from the Office Hour Aug 31, 2021
@antonbabenko antonbabenko merged commit 5e42610 into master Aug 31, 2021
@antonbabenko antonbabenko deleted the github-repos-content branch August 31, 2021 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryantbiggs bryantbiggs bryantbiggs left review comments

@daroga0002 daroga0002 daroga0002 approved these changes

@barryib barryib Awaiting requested review from barryib

@DrFaust92 DrFaust92 Awaiting requested review from DrFaust92

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antonbabenko @bryantbiggs @daroga0002