Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential issue with LicenseInfoFromFiles #1232

Open
armintaenzertng opened this issue Jun 16, 2023 · 3 comments
Open

Potential issue with LicenseInfoFromFiles #1232

armintaenzertng opened this issue Jun 16, 2023 · 3 comments

Comments

@armintaenzertng
Copy link

While perusing the SPDX generation code, I noticed that here all licenses from files are converted to LicenseRef-style license identifiers. This means that these should all show up in ExtractedLicensingInfo. However, for ExtractedLicensingInfo only non-valid licenses are written here and here, meaning that valid licenses would be referenced via LicenseRef-Identifiers that are never defined.
I don't have a reproducible example yet, as the ones I tried so far don't contain LicenseInfoFromFiles. This may also be the reason why this hasn't come up yet?

@rnjudge
Copy link
Contributor

rnjudge commented Jun 16, 2023

Thanks for the heads up @armintaenzertng. In order to get license info in files try using the Scancode extension. In the mean time, I'll try to dig a little deeper in the code and make sure this is actually a bug.

@armintaenzertng
Copy link
Author

I tried using the scancode extension, but ran into the bug described in #1202. I'll post my report there.

@rnjudge
Copy link
Contributor

rnjudge commented Jun 29, 2023

@armintaenzertng If you try with this branch you should be able to run it: https://github.com/rnjudge/tern/tree/issue-1202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants