Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node 0.4.2 buffers vs strings problem causes broken int and float decoding #2

Open
tperkis opened this issue Mar 7, 2011 · 0 comments

Comments

@tperkis
Copy link

tperkis commented Mar 7, 2011

ints and floats are not unpacked correctly under node 0.4.2 due to conversion of input data from a binary buffer to a string in _readString() method. the 'rest' return value, should remain a binary buffer, and substr() and substring() calls in other _read{Int,Float, etc} functions should be replaced by slice().

I fixed this in my fork but being a github noob I'm not sure what else to do about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant