Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent naming of Wormhole devices #13

Open
afaerber opened this issue Sep 14, 2024 · 1 comment
Open

Inconsistent naming of Wormhole devices #13

afaerber opened this issue Sep 14, 2024 · 1 comment
Labels
bug Something isn't working good-first-issue Good for newcomers

Comments

@afaerber
Copy link
Contributor

afaerber commented Sep 14, 2024

Documentation, website (with exception of the very top of Wormhole page) and packaging name the cards "n150s" (and "n300s") but get_board_type() names them just "n150" and "n300" respectively. Those shortened names are then displayed in tt-smi.

Was that a last-minute Marketing name change not yet reflected in code and parts of the web page, or are there non-s variants planned that this omission intentionally prepares for?

While n150 is not compared in tt-smi or tt-flash, tt-smi does check for n300 currently.

Independently, tt-flash does its own change_to_public_name() mapping, also omitting the s.

@afaerber
Copy link
Contributor Author

tt-topology has further get_board_type() comparisons for both "n150" and "n300".

@milank94 milank94 added the bug Something isn't working label Oct 30, 2024
@warthog9 warthog9 added enhancement New feature or request and removed bug Something isn't working labels Nov 5, 2024
@milank94 milank94 added bug Something isn't working good-first-issue Good for newcomers and removed enhancement New feature or request labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good-first-issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants