Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port over missing ops into ttir builder infra. #1539

Open
tapspatel opened this issue Dec 9, 2024 · 2 comments
Open

Port over missing ops into ttir builder infra. #1539

tapspatel opened this issue Dec 9, 2024 · 2 comments
Assignees

Comments

@tapspatel
Copy link
Collaborator

tapspatel commented Dec 9, 2024

The following ops (curated from program.fbs) need to be ported into python/test_infra/ttir_builder.py

Typecast
Cbrt
Minimum
Ceil
Sin
Cos
Log
Log1p
Expm1
Sign
Remainder
IsFinite
Floor
Where
Gelu
LogicalXor
Clamp
LeakyRelu
Scatter
Tan
Tanh
Embedding

example

def le(self, in0: Operand, in1: Operand) -> OpView:
        return self.eltwise_proxy(torch.le, ttir.LessEqualOp, [in0, in1])

Need to provide op function, a torch golden function, and add a test case in python/test_infra/test_ttir_ops.py for all passing tests in both ttnn and ttmetal runtime. Some ops may not be completely implemented in runtime (ttnn or ttmetal) which should be checked. A final golden check should also be done on these tests using ttrt.

ttrt run some_flatbuffer.ttnn --golden

If golden check fails, add tests with repro instructions to #1219

@nsmithtt nsmithtt assigned ctodTT and unassigned nsmithtt Dec 9, 2024
@nsmithtt
Copy link
Contributor

nsmithtt commented Dec 9, 2024

I also wonder if there's a way we can embed the type of golden check in the flatbuffer that ttrt can snoop before running the test. It's otherwise kind of awkward to organize our tests around the method of validation.

@tapspatel
Copy link
Collaborator Author

Embedding op is blocked on this golden infra support: #1404 which is blocking LLama model run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants