From 7a967945e497cf7e5e23e7d1b842d6c63b90958a Mon Sep 17 00:00:00 2001 From: Bill Teng Date: Thu, 16 Jan 2025 00:23:52 +0000 Subject: [PATCH] remove LFS references now that metal/SFPI/UMD have no LFS assets --- .github/Dockerfile.base | 1 - docs/src/build.md | 28 ---------------------------- runtime/tools/python/setup.py | 1 - 3 files changed, 30 deletions(-) diff --git a/.github/Dockerfile.base b/.github/Dockerfile.base index e6fc33757..e987b1217 100644 --- a/.github/Dockerfile.base +++ b/.github/Dockerfile.base @@ -12,7 +12,6 @@ RUN apt-get update && apt-get install -y \ python3-venv \ python3-pip \ git \ - git-lfs \ libhwloc-dev \ pandoc \ libtbb-dev \ diff --git a/docs/src/build.md b/docs/src/build.md index 339b187d2..b415ca08d 100644 --- a/docs/src/build.md +++ b/docs/src/build.md @@ -125,14 +125,6 @@ brew install graphviz ## Dependencies -### Ubuntu Common - -Make sure to have Git LFS installed. You can install it with the following command: - -```bash -sudo apt-get install git-lfs -``` - ### Ubuntu 22.04 On Ubuntu 22.04 we need to install clang, ninja, and to update the version of cmake because 3.20 is the minimum required for this project. @@ -208,26 +200,6 @@ CMake Error at CMakeLists.txt:2 (project): If you get the following error, it means you need to install clang which you can do with `sudo apt install clang` on Ubuntu. -### `sfpi`, `trisc`, `ncrisc` build failure - -``` -tt-forge-fe/third_party/tt-mlir/third_party/tt-metal/src/tt-metal/tt_metal/third_party/sfpi/compiler/bin/riscv32-unknown-elf-g++: 1: version: not found -tt-forge-fe/third_party/tt-mlir/third_party/tt-metal/src/tt-metal/tt_metal/third_party/sfpi/compiler/bin/riscv32-unknown-elf-g++: 2: oid: not found -size: '1961632': No such file -size: '1961632': No such file -size: '1961632': No such file -Always | FATAL | ncrisc build failed -``` - -If you got the above error, it means that SFPI or similar component build failed. First, make sure you have GIT LFS setup (e.g. sudo apt-get install git-lfs). Then, try to pull SFPI submodule manually: - -```bash -cd third_party/tt-metal/src/tt-metal -git submodule foreach 'git lfs fetch --all && git lfs pull' -``` - -Then, try to build again. - ## Common Runtime Errors ### Debugging python on macOS diff --git a/runtime/tools/python/setup.py b/runtime/tools/python/setup.py index d754250e0..3a82455e5 100644 --- a/runtime/tools/python/setup.py +++ b/runtime/tools/python/setup.py @@ -158,7 +158,6 @@ "third_party/sfpi/compiler/share", "third_party/sfpi/compiler/compiler", "third_party/fmt", - "third_party/lfs", "third_party/pybind11", "third_party/taskflow", "third_party/json",