Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tt-metal(ium) level tests such as pgm dispatch benchmarks to use new benchmark data infra #15979

Open
Tracked by #10718
tt-rkim opened this issue Dec 12, 2024 · 2 comments
Labels
data-collection collab ticket with data science team infra-ci infrastructure and/or CI changes P2 perf for issues tracking performance problems/improvements performance monitoring Feature or bug related to performance monitoring

Comments

@tt-rkim
Copy link
Collaborator

tt-rkim commented Dec 12, 2024

What is the context?

There is some existing benchmarking infrastructure that can record performance results or benchmarks and upload them to a central Superset dashboard for later presentation and consumption.

The tools themselves were written by @skhorasganiTT and are housed in models/perf/benchmarking_utils.py. Infra team manages the infrastructure that transforms and submits the data to data teams' pipeline.

An example of use is here: falcon7b_common/demo/demo.py

Image

Though it was written with models in mind, it should be easily applicable to runtime-level benchmarks.

What is there to do?

The current infrastructure is only supported in Python and was written with models in mind.

So, the following will likely need to be done by runtime team:

  • Get a feeling for what kind of insights Superset can offer
  • Decide what kind of benchmarks the team would like to see
  • Start making C++ versions of these benchmarking tools
  • Ensure data format compatibility with the current infrastructure (usually would mean Pydantic in Python, but need to come up with alternatives for C++ workflows w/ infra team)
  • Instrument current u-benchmarks to use these utilities
@tt-rkim tt-rkim added infra-ci infrastructure and/or CI changes performance monitoring Feature or bug related to performance monitoring P2 perf for issues tracking performance problems/improvements data-collection collab ticket with data science team and removed performance monitoring Feature or bug related to performance monitoring P2 perf for issues tracking performance problems/improvements labels Dec 12, 2024
@jbaumanTT
Copy link
Contributor

I'm thinking it might make sense to export the data using the csv or json format supported by https://github.com/google/benchmark, which should be flexible enough for our purposes.

@tt-rkim
Copy link
Collaborator Author

tt-rkim commented Dec 17, 2024

Do we use that? We should.

We can definitely edit the final schema however we choose to fit the requirements from data team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data-collection collab ticket with data science team infra-ci infrastructure and/or CI changes P2 perf for issues tracking performance problems/improvements performance monitoring Feature or bug related to performance monitoring
Projects
None yet
Development

No branches or pull requests

2 participants