Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce size of MicroProfiler #2725

Open
andresovela opened this issue Oct 18, 2024 · 4 comments
Open

Reduce size of MicroProfiler #2725

andresovela opened this issue Oct 18, 2024 · 4 comments

Comments

@andresovela
Copy link
Contributor

The MicroProfiler class has these buffers:

const char* tags_[kMaxEvents];
uint32_t start_ticks_[kMaxEvents];
uint32_t end_ticks_[kMaxEvents];

struct TicksPerTag {
  const char* tag;
  uint32_t ticks;
};

TicksPerTag total_ticks_per_tag[kMaxEvents];

We need 20 bytes per event, so an instance of MicroProfiler uses 80 KB of RAM, even if the model you're profiling has only a few nodes.

Copy link
Contributor

"This issue is being marked as stale due to inactivity. Remove label or comment to prevent closure in 5 days."

@github-actions github-actions bot added the Stale label Nov 13, 2024
@andresovela
Copy link
Contributor Author

#2724 is still open

@ddavis-2015 ddavis-2015 removed the Stale label Nov 13, 2024
Copy link
Contributor

github-actions bot commented Dec 9, 2024

"This issue is being marked as stale due to inactivity. Remove label or comment to prevent closure in 5 days."

@github-actions github-actions bot added the Stale label Dec 9, 2024
@andresovela
Copy link
Contributor Author

#2724 is still open

@github-actions github-actions bot removed the Stale label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants