Fix werkzeug logging at INFO by forcibly unsetting werkzeug log level #2383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wchargin
approved these changes
Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2028
This adds a workaround to WerkzeugServer to ensure that werkzeug log messages continue to be subject to TensorBoard's overall log level setting (
--verbosity). This basically papers over a change introduced in 0.15.0 (specifically pallets/werkzeug@4cf77d2) that causes Werkzeug to no longer take root logger configuration into account when setting its own logger level to INFO, and resulted in #2028 where werkzeug HTTP request logs were emitted without respecting the TB log level setting.I also updated our workspace dep on Werkzeug to the latest version, 0.15.4.
Tested by running tensorboard built both with and without the workspace dep update (aka with both 0.11.15 and 0.15.4 werkzeug versions), and confirmed that no HTTP request logs are emitted to the console by default, but that they appear when passing
--verbosity=0(min log level INFO).