Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update WitWidget pip version #2283

Merged
merged 1 commit into from
May 28, 2019
Merged

Update WitWidget pip version #2283

merged 1 commit into from
May 28, 2019

Conversation

jameswex
Copy link
Contributor

  • Motivation for features / changes

Release new WitWidget with latest changes.

  • Technical description of changes

Updated version number
Fixed issue with custom predict functions found during testing - check explicitly for dict so as to capture edge cases in prediction lists.

  • Screenshots of UI changes

N/A

  • Detailed steps to verify changes work correctly (as executed by you)

Ran all our different colabs with a locally-uploaded version of this new pip package. Verified correctness.

@jameswex
Copy link
Contributor Author

@tolga-b please review

@jameswex jameswex requested a review from stephanwlee May 28, 2019 15:13
stephanwlee
stephanwlee approved these changes May 28, 2019
View reviewed changes
Copy link
Contributor

@stephanwlee stephanwlee left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should probably be a test :)

@jameswex jameswex merged commit 39c80de into tensorflow:master May 28, 2019
@jameswex jameswex deleted the witpip branch May 28, 2019 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolga-b tolga-b tolga-b approved these changes

@stephanwlee stephanwlee stephanwlee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jameswex @stephanwlee @tolga-b