[profile] make trace viewer respect --path_prefix #2276
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2263.
The trace viewer logic was hardcoded to use absolute paths (relative to the hostname), which doesn't work when
--path_prefix
is set. As far as I can tell there is no particular reason why the trace viewer shouldn't use relative path names like the rest of TensorBoard, and the code that forced the absolute path has been around since the profile plugin was introduced, so I suspect it's just outdated.Tested by running
tensorboard --path_prefix /mypath/
and then putting nginx in front of it as follows:Confirmed that the previously broken trace viewer now loads demo data correctly when accessed via
http://localhost:8080/mypath/
. I also ran tensorboard without a path prefix and confirmed the trace viewer still loads correctly in that case as well.