build: fix lint errors #2274
Merged
build: fix lint errors #2274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Changes in #2267 displeased the Google linter: `list(my_depset)` is banned because it’s not obvious that this forces iteration, so we switch to the far clearer `.to_list()` everywhere. The venerable linter further demands that docstrings be added, even for drive-by fixes. Test Plan: A test import succeeds; all Google-internal tests pass. wchargin-branch: import-lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changes in #2267 displeased the Google linter:
list(my_depset)isbanned because it’s not obvious that this forces iteration, so we switch
to the far clearer
.to_list()everywhere.The venerable linter further demands that docstrings be added, even for
drive-by fixes.
Test Plan:
A test import succeeds; all Google-internal tests pass.
wchargin-branch: import-lint