Fix long type not found for json input in python3 #2269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameswex
approved these changes
May 22, 2019
|
@stephanwlee please review. |
stephanwlee
reviewed
May 22, 2019
There was a problem hiding this comment.
The change looks straightforward but I am surprised by lack of python deps in http://go/gh/tensorflow/tensorboard/blob/master/tensorboard/plugins/interactive_inference/witwidget/BUILD.
How does it work? (if it works because of transitive deps, wouldn't it be brittle?)
|
You are right. We realized that BUILD file for witwidget is missing a lot of dependencies and it mainly works because the pip package depends on tensorflow which has them. We will update the witwidget BUILD file in a separate PR. |
stephanwlee
approved these changes
May 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
long type does not exist in python 3, changed type testing to six.integer types from long to prevent errors when wit is used with json inputs.
Technical description of changes
Screenshots of UI changes
None
Detailed steps to verify changes work correctly (as executed by you)
Tested cloud xgboost model with python 3 kernel in colab.
Alternate designs / implementations considered
None