Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hparams: account for proto nondeterminism in tests #2235

Merged
merged 2 commits into from
May 15, 2019
Merged

hparams: account for proto nondeterminism in tests #2235

merged 2 commits into from
May 15, 2019

Commits on May 15, 2019

  1. hparams: account for proto nondeterminism in tests 

    Summary:
This test seems to be fine in open-source land, but failed 18/32 times
within Google, because the wire format order for maps is undefined:
<https://developers.google.com/protocol-buffers/docs/proto3#maps>

Test Plan:
Within google3, cherry-pick this patch onto <http://cl/247655537>, then
run `:summary_v2_notf_test` with `--runs_per_test=128` to check for
flakiness.

wchargin-branch: hparams-test-deflake
    @wchargin
    wchargin committed May 15, 2019
    Configuration menu
    Copy the full SHA
    7d0411e View commit details
    Browse the repository at this point in the history

  2. [integrate] 

    wchargin-branch: hparams-test-deflake
    @wchargin
    wchargin committed May 15, 2019
    Configuration menu
    Copy the full SHA
    4b691c3 View commit details
    Browse the repository at this point in the history