graph: Fix JSE when switching node selection #2232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repro steps: 1. Select a run that has more than one tags 2. Select a tag with RunMetadata 3. Select a node 4. Select the default tag 5. Click nodes around and see JSEs We have nested dom-ifs to prevent `getTotalMicros` from being called. However, this is only effective when the DOM is not mounted but this assumption does not hold after first render (if=true).
wchargin
approved these changes
May 15, 2019
|
JavaScript Exception. Maybe that acronym is not widely used |
|
Ah, got it. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repro steps:
We have nested dom-ifs to prevent
getTotalMicrosfrom being called.However, this is only effective when the DOM is not mounted but this
assumption does not hold after first render (if=true).