TensorFlow-Graphics Mesh Visualization Plugin (server side) #2168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
podlipensky
force-pushed
the
tf-graphics
branch
from
902a509
to
b8325aa
Compare
podlipensky
changed the title
stephanwlee
reviewed
Apr 30, 2019
stephanwlee
reviewed
Apr 30, 2019
stephanwlee
reviewed
Apr 30, 2019
stephanwlee
requested review from
wchargin
and removed request for
manivaradarajan and
stephanwlee
wchargin
requested review from
manivaradarajan
and removed request for
manivaradarajan
wchargin
reviewed
May 3, 2019
nfelt
reviewed
May 3, 2019
wchargin
approved these changes
May 3, 2019
stephanwlee
added a commit
to stephanwlee/tensorboard
that referenced
this pull request
May 6, 2019
At PR tensorflow#2168, it was recommended to call mesh_visualizer plugin a mesh plugin. As a result, the Python code lives in tensorboard/plugins/mesh while the frontend lives in tensorboard/plugins/mesh_visualizer. This change moves frontend code into t/p/mesh.
stephanwlee
added a commit
that referenced
this pull request
May 21, 2019
At PR #2168, it was recommended to call mesh_visualizer plugin a mesh plugin. As a result, the Python code lives in tensorboard/plugins/mesh while the frontend lives in tensorboard/plugins/mesh_visualizer. This change moves frontend code into t/p/mesh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial pull request for tf-graphics Mesh Visualization plugin.
Note that part of client-side code of the plugin comes from tensorflow/graphics repo.
Also plugin misses demo app which will be added later.