From 9c06f56749c38c21503bd0d47fccf46e0e869b37 Mon Sep 17 00:00:00 2001 From: William Chargin Date: Tue, 15 Jan 2019 10:21:24 -0800 Subject: [PATCH 1/2] build: unpin tf-nightly version Summary: This reverts part of d285c7de73a09e9ece5a13368a58c00e1dcabda9 because the upstream package has been fixed. Test Plan: Running `from tensorflow.compat import v1` fails in the 20190114 virtualenv but works in the 20190115 virtualenv. Building the Pip package with `bazel run //tensorboard/pip_package:build_pip_package` also works. wchargin-branch: unpin-tf-nightly --- .travis.yml | 4 +--- tensorboard/pip_package/build_pip_package.sh | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/.travis.yml b/.travis.yml index d05d799f9a4..b2b21e48687 100644 --- a/.travis.yml +++ b/.travis.yml @@ -96,9 +96,7 @@ install: pip install -I tensorflow ;; NIGHTLY) - # TODO(@wchargin): Unpin once tensorflow/tensorflow#24867 is merged: - # https://github.com/tensorflow/tensorflow/pull/24867 - pip install -I tf-nightly==1.13.0.dev20190104 + pip install -I tf-nightly ;; *) pip install -I tensorflow=="${TF}" diff --git a/tensorboard/pip_package/build_pip_package.sh b/tensorboard/pip_package/build_pip_package.sh index 8321ef97a8c..754fa838680 100755 --- a/tensorboard/pip_package/build_pip_package.sh +++ b/tensorboard/pip_package/build_pip_package.sh @@ -38,9 +38,7 @@ while [ "$#" -gt 0 ]; do done smoke() { - # TODO(@wchargin): Unpin once tensorflow/tensorflow#24867 is merged: - # https://github.com/tensorflow/tensorflow/pull/24867 - TF_PACKAGE=tf-nightly==1.13.0.dev20190104 + TF_PACKAGE=tf-nightly if [ -n "$TF_VERSION" ]; then TF_PACKAGE="tensorflow==${TF_VERSION}" fi From 6700808112a1b479f33a0531d981533c7c0dc04d Mon Sep 17 00:00:00 2001 From: William Chargin Date: Thu, 17 Jan 2019 10:03:55 -0800 Subject: [PATCH 2/2] [dummy commit to trigger Travis] wchargin-branch: unpin-tf-nightly