From 72b3c15f1f15643def7126f5bfa0c2cb57f25796 Mon Sep 17 00:00:00 2001
From: Qiumin Xu <qiuminxu@google.com>
Date: Mon, 10 Dec 2018 17:36:52 -0800
Subject: [PATCH 1/2] Add a breakdown of step time to overview page.

---
 .../plugins/profile/overview_page/overview-page.html      | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/tensorboard/plugins/profile/overview_page/overview-page.html b/tensorboard/plugins/profile/overview_page/overview-page.html
index 64be9becd63..58156dcf2fd 100644
--- a/tensorboard/plugins/profile/overview_page/overview-page.html
+++ b/tensorboard/plugins/profile/overview_page/overview-page.html
@@ -105,6 +105,8 @@
         <paper-card heading="Performance Summary">
           <div class="card-content">
             <p><b>Average step time</b> (lower is better): <b><span class="steptime-average" >[[_steptime_ms_average]] ms</span> </b> <i style="opacity:0.7">(standard deviation = <span>[[_steptime_ms_stddev]]</span> ms)</i></p>
+            <p>- Average infeed: <span>[[_infeed_ms_average]]</span> ms</p>
+            <p>- Average compute: <span>[[_compute_ms_average]]</span> ms</p>
             <p><b>Host idle time</b> (lower is better): <span>[[_host_idle_time_percent]]</span></p>
             <p><b>TPU idle time</b> (lower is better): <span>[[_device_idle_time_percent]]</p>
             <p><b>Utilization of TPU Matrix Units</b> (higher is better): <span>[[_mxu_utilization_percent]]</span></p>
@@ -206,6 +208,8 @@
        _mxu_utilization_percent: { type: String },
        _steptime_ms_average: { type: String },
        _steptime_ms_stddev: { type: String },
+       _infeed_ms_average: { type: String },
+       _compute_ms_average: { type: String },
        _top_ops_heading: { type: String },
        _error_message: { type: String },
        _host_count: { type: String },
@@ -271,6 +275,10 @@
            inputAnalysisJson.p['steptime_ms_average'];
        this._steptime_ms_stddev =
            inputAnalysisJson.p['steptime_ms_standard_deviation'];
+       this._infeed_ms_average =
+           inputAnalysisJson.p['compute_ms_average'];
+       this._compute_ms_average =
+           inputAnalysisJson.p['infeed_ms_average'];
      },
      /* Displays run time information */
      _showRunEnvironment : function(runEnvironmentJson) {

From 750069a2cad41fb543ed4c9aa3ae6badbabb4b07 Mon Sep 17 00:00:00 2001
From: Qiumin Xu <qiuminxu@google.com>
Date: Wed, 12 Dec 2018 19:29:29 -0800
Subject: [PATCH 2/2] Use <ul> and <li> tags for the step time breakdown

---
 .../plugins/profile/overview_page/overview-page.html   | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/tensorboard/plugins/profile/overview_page/overview-page.html b/tensorboard/plugins/profile/overview_page/overview-page.html
index 58156dcf2fd..9f21a8a2005 100644
--- a/tensorboard/plugins/profile/overview_page/overview-page.html
+++ b/tensorboard/plugins/profile/overview_page/overview-page.html
@@ -105,8 +105,10 @@
         <paper-card heading="Performance Summary">
           <div class="card-content">
             <p><b>Average step time</b> (lower is better): <b><span class="steptime-average" >[[_steptime_ms_average]] ms</span> </b> <i style="opacity:0.7">(standard deviation = <span>[[_steptime_ms_stddev]]</span> ms)</i></p>
-            <p>- Average infeed: <span>[[_infeed_ms_average]]</span> ms</p>
-            <p>- Average compute: <span>[[_compute_ms_average]]</span> ms</p>
+            <ul hidden$=[[!_infeed_ms_average]]>
+              <li>Average infeed: <span>[[_infeed_ms_average]]</span> ms</li>
+              <li>Average compute: <span>[[_compute_ms_average]]</span> ms</li>
+            </ul>
             <p><b>Host idle time</b> (lower is better): <span>[[_host_idle_time_percent]]</span></p>
             <p><b>TPU idle time</b> (lower is better): <span>[[_device_idle_time_percent]]</p>
             <p><b>Utilization of TPU Matrix Units</b> (higher is better): <span>[[_mxu_utilization_percent]]</span></p>
@@ -208,8 +210,8 @@
        _mxu_utilization_percent: { type: String },
        _steptime_ms_average: { type: String },
        _steptime_ms_stddev: { type: String },
-       _infeed_ms_average: { type: String },
-       _compute_ms_average: { type: String },
+       _infeed_ms_average: { type: String, value: '' },
+       _compute_ms_average: { type: String, value: '' },
        _top_ops_heading: { type: String },
        _error_message: { type: String },
        _host_count: { type: String },