Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TensorBoard doesn’t build with Bazel 0.25.0 #2181

Closed
wchargin opened this issue May 2, 2019 · 1 comment · Fixed by #2243
Closed

TensorBoard doesn’t build with Bazel 0.25.0 #2181

wchargin opened this issue May 2, 2019 · 1 comment · Fixed by #2243
Labels
type:build/install

Comments

@wchargin
Copy link
Contributor

wchargin commented May 2, 2019

New incompatible flags:

$ ~/Downloads/bazel-0.25.0-linux-x86_64 build //tensorboard
Starting local Bazel server and connecting to it...
ERROR: /HOMEDIR/.bazel-output-base/external/org_tensorflow/third_party/gpus/cuda_configure.bzl:115:1: load() statements must be called before any other statement. First non-load() statement appears at /HOMEDIR/.bazel-output-base/external/org_tensorflow/third_party/gpus/cuda_configure.bzl:26:1. Use --incompatible_bzl_disallow_load_after_statement=false to temporarily disable this check.
ERROR: error loading package '': in /HOMEDIR/.bazel-output-base/external/org_tensorflow/tensorflow/workspace.bzl: Label '@org_tensorflow//third_party:nccl/nccl_configure.bzl' crosses boundary of subpackage '@org_tensorflow//third_party/nccl' (perhaps you meant to put the colon here: '@org_tensorflow//third_party/nccl:nccl_configure.bzl'?)
ERROR: error loading package '': in /HOMEDIR/.bazel-output-base/external/org_tensorflow/tensorflow/workspace.bzl: Label '@org_tensorflow//third_party:nccl/nccl_configure.bzl' crosses boundary of subpackage '@org_tensorflow//third_party/nccl' (perhaps you meant to put the colon here: '@org_tensorflow//third_party/nccl:nccl_configure.bzl'?)
INFO: Elapsed time: 3.352s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded)

But an error even when flipping those:

$ ~/Downloads/bazel-0.25.0-linux-x86_64 build --incompatible_bzl_disallow_load_after_statement=false --incompatible_disallow_load_labels_to_cross_package_boundaries=false //tensorboard
ERROR: /HOMEDIR/.bazel-output-base/external/io_bazel_rules_webtesting/web/repositories.bzl:17:1: file '@bazel_gazelle//:deps.bzl' does not contain symbol 'go_repository'
ERROR: error loading package '': Extension file 'web/repositories.bzl' has errors
ERROR: error loading package '': Extension file 'web/repositories.bzl' has errors
INFO: Elapsed time: 0.538s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded)

Confirmed still fine with Bazel 0.24.1.
@nfelt
Copy link
Contributor

nfelt commented May 2, 2019

It looks like rules_webtesting has had failing builds on Travis for its master branch for at least a month due to build errors like this:

https://travis-ci.org/bazelbuild/rules_webtesting/builds/517398510 <-- latest build at master, 24 days ago
https://travis-ci.org/bazelbuild/rules_webtesting/builds/513158130 <-- same failure, over a month ago

@rmothukuru rmothukuru self-assigned this May 3, 2019
@Ark-kun Ark-kun mentioned this issue May 7, 2019
Closed
@rmothukuru rmothukuru removed their assignment May 8, 2019
wchargin added a commit that referenced this issue May 17, 2019
@wchargin
Fix build for Bazel 0.25
b7cd1cc 
Summary:
Fixes #2181. Thankfully, the `rules_webtesting` scene has gotten a bit
saner, requiring fewer explicitly defined transitive dependencies,
though it looks like the ones that we do have need to be manually kept
in sync (e.g., `bazel_skylib`).

Test Plan:
Running `bazel build //...` and `bazel test //...` works in Bazel 0.25.2
in both Python 2 and Python 3.

wchargin-branch: bazel-0.25
@wchargin wchargin mentioned this issue May 17, 2019
Merged
wchargin added a commit that referenced this issue May 18, 2019
@wchargin
Fix build for Bazel 0.25 (#2243)
52a9d40 
Summary:
Fixes #2181. Thankfully, the `rules_webtesting` scene has gotten a bit
saner, requiring fewer explicitly defined transitive dependencies,
though it looks like the ones that we do have need to be manually kept
in sync (e.g., `bazel_skylib`).

Test Plan:
Running `bazel build //...` and `bazel test //...` works in Bazel 0.25.2
in both Python 2 and Python 3.

wchargin-branch: bazel-0.25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:build/install
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix build for Bazel 0.25 tensorflow/tensorboard
3 participants
@nfelt @wchargin @rmothukuru