We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi!
Thanks for a great tool!
Issue: It is not possible to disable "purging of orphaned data" through the purge_orphaned_data flag.
purge_orphaned_data
The problem is with the argparse flag parsing[1]: using type=bool means the string argument will be converted to boolean, e.g. bool('False') => True.
`import argparse parser = argparse.ArgumentParser(prog='foo') parser.add_argument('--purge_orphaned_data', metavar='BOOL', type=bool, nargs=1, default=True)
In [6]: parser.parse_args('--purge_orphaned_data=False'.split()) Out[6]: Namespace(purge_orphaned_data=[True])`
Ways to fix this:
Note sure if the "absl flag integration" presents additional difficulties though [2].
[1] https://github.com/tensorflow/tensorboard/blob/master/tensorboard/plugins/core/core_plugin.py#L302 [2] https://github.com/tensorflow/tensorboard/blob/master/tensorboard/program.py#L55
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Hi!
Thanks for a great tool!
Issue: It is not possible to disable "purging of orphaned data" through the
purge_orphaned_data
flag.The problem is with the argparse flag parsing[1]: using type=bool means the string argument will be converted to boolean, e.g. bool('False') => True.
`import argparse
parser = argparse.ArgumentParser(prog='foo')
parser.add_argument('--purge_orphaned_data', metavar='BOOL', type=bool, nargs=1, default=True)
In [6]: parser.parse_args('--purge_orphaned_data=False'.split())
Out[6]: Namespace(purge_orphaned_data=[True])`
Ways to fix this:
Note sure if the "absl flag integration" presents additional difficulties though [2].
[1] https://github.com/tensorflow/tensorboard/blob/master/tensorboard/plugins/core/core_plugin.py#L302
[2] https://github.com/tensorflow/tensorboard/blob/master/tensorboard/program.py#L55
The text was updated successfully, but these errors were encountered: