From ae45d4c1699f236d0c8c612a827ce5ac3cff24a7 Mon Sep 17 00:00:00 2001 From: Zoey Li <31378877+alicialics@users.noreply.github.com> Date: Tue, 4 Apr 2023 18:43:50 +0000 Subject: [PATCH] rename params --- .../vz_projector/vz-projector-projections-panel.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tensorboard/plugins/projector/vz_projector/vz-projector-projections-panel.ts b/tensorboard/plugins/projector/vz_projector/vz-projector-projections-panel.ts index 010476e951a..1bd4a27528a 100644 --- a/tensorboard/plugins/projector/vz_projector/vz-projector-projections-panel.ts +++ b/tensorboard/plugins/projector/vz_projector/vz-projector-projections-panel.ts @@ -398,8 +398,8 @@ class ProjectionsPanel extends LegacyElementMixin(PolymerElement) { this.customSelectedSearchByMetadataOption = this.searchByMetadataOptions[Math.max(0, searchByMetadataIndex)]; } - public showTab(id: ProjectionType) { - const tab = this.$$('.ink-tab[data-tab="' + id + '"]') as HTMLElement; + public showTab(projection: ProjectionType) { + const tab = this.$$('.ink-tab[data-tab="' + projection + '"]') as HTMLElement; const allTabs = this.root?.querySelectorAll('.ink-tab'); if (allTabs) { for (let i = 0; i < allTabs.length; i++) { @@ -414,7 +414,7 @@ class ProjectionsPanel extends LegacyElementMixin(PolymerElement) { } } util.classed( - this.$$('.ink-panel-content[data-panel="' + id + '"]') as HTMLElement, + this.$$('.ink-panel-content[data-panel="' + projection + '"]') as HTMLElement, 'active', true ); @@ -427,7 +427,7 @@ class ProjectionsPanel extends LegacyElementMixin(PolymerElement) { this.style.height = main.clientHeight + 'px'; }); } - this.beginProjection(id); + this.beginProjection(projection); } private beginProjection(projection: ProjectionType) { if (this.polymerChangesTriggerReprojection === false) {