Skip to content

Commit 62931f1

Browse files
authored
Updates GH actions upload- and download-artifact to v4 (#6936)
As communicated in [this announcement](https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/), v3 of these actions is deprecated. I followed [this example](https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md#multiple-uploads-to-the-same-named-artifact) matching our use of these actions.
1 parent 71bd61a commit 62931f1

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

.github/workflows/ci.yml

+6-2
Original file line numberDiff line numberDiff line change
@@ -130,10 +130,14 @@ jobs:
130130
bazel run //tensorboard/pip_package:build_pip_package -- /tmp/tb_nightly_pip_package
131131
- name: 'Upload Pip package as an artifact (master branch TF build only)'
132132
# Prevent uploads when running on forks or non-master branch.
133+
#
134+
# Note that upload-artifact GH action, starting in v4, requires the name of the uploaded
135+
# file(s) to be unique per workflow run, so make sure that the name is unique for each
136+
# "matrix" combination for which this is executed.
133137
if: matrix.tf_version_id == 'tf' && github.repository == 'tensorflow/tensorboard' && github.ref == 'refs/heads/master'
134-
uses: actions/upload-artifact@83fd05a356d7e2593de66fc9913b3002723633cb # v3.1.1
138+
uses: actions/upload-artifact@v4
135139
with:
136-
name: tb-nightly
140+
name: tb-nightly_py${{ matrix.python_version }}
137141
path: /tmp/tb_nightly_pip_package/*
138142

139143
build-data-server-pip:

.github/workflows/nightly-release.yml

+4-2
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,11 @@ jobs:
2020
if: github.repository == 'tensorflow/tensorboard'
2121
steps:
2222
- name: Download pip package
23-
uses: actions/download-artifact@v3
23+
uses: actions/download-artifact@v4
2424
with:
25-
name: tb-nightly
25+
pattern: tb-nightly_py*
26+
# Download all matching artifacts in the same directory (specified by path)
27+
merge-multiple: true
2628
path: wheels
2729
- name: Install Twine
2830
run: pip install twine

0 commit comments

Comments
 (0)